[FIX] Asset group decimal error #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When asset weights in the same group having decimal places over 18, there could be the case where the resulted weight is decreased when it shouldn't. Considering a group where
previous weights: A = 1, B = 0
updated weights: A = 1/3, B = 2/3
But due to precision loss, A = 0.333333333333333333, B = 0.666666666666666666 which resulted in 0.999999999999999999 which is viewed as decreasing weight and bypass the limiter (decreasing weight shoud not be prohibited even if it's not yet below the bound as it improves the pool balances but this case does not).
The fix is delaying division and sum the normalized value first as opposed to just sum the denom weights.