Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendor table key must be upper-case #178

Closed
kengu opened this issue Feb 9, 2024 · 2 comments
Closed

Vendor table key must be upper-case #178

kengu opened this issue Feb 9, 2024 · 2 comments
Assignees
@kengu

Comments

@kengu
Copy link
Contributor

kengu commented Feb 9, 2024 •
edited
Loading

Problem
Vendor information is always null, even for known mac-address ranges.

Analysis
Keys in mac-vendors-export.csv are semicolon-separated in upper case.

On line 20 in VendorTable the first three mac address parts is joined without upper case.

Resolution
Add .toUpperCase()to arpData.macAddress.split(pattern).sublist(0, 3).join()on line 20
kengu added a commit to kengu/network_tools that referenced this issue Feb 9, 2024
@kengu
Fixed issue osociety#178
8b85940
kengu added a commit to kengu/network_tools that referenced this issue Feb 9, 2024
@kengu
Fixed issue osociety#178
a2ef232
@kengu kengu changed the title Vendor table key is semicolon-separated Vendor table key must be upper-case Feb 9, 2024
@kengu kengu mentioned this issue Feb 9, 2024
Merged
@guyluz11
Copy link
Collaborator

Nice catch

@guyluz11
Copy link
Collaborator

Closing, will be merged in the new version.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kengu kengu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kengu @guyluz11