Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding more ip of mdns #165

Merged
merged 6 commits into from
Dec 2, 2023
Merged

Conversation

guyluz11
Copy link
Collaborator

@guyluz11 guyluz11 commented Nov 25, 2023

Mdns search can now find more reliably IPs of devices.
Mdns search now includes results of ipv6 devices as well.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (a34ca22) 77.08% compared to head (5bf1166) 74.94%.

Files Patch % Lines
lib/src/mdns_scanner/mdns_scanner.dart 4.16% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #165      +/-   ##
==========================================
- Coverage   77.08%   74.94%   -2.14%     
==========================================
  Files          19       19              
  Lines         480      491      +11     
==========================================
- Hits          370      368       -2     
- Misses        110      123      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@git-elliot
Copy link
Collaborator

git-elliot commented Nov 29, 2023

@guyluz11 would merging this close #164?

@git-elliot git-elliot linked an issue Nov 29, 2023 that may be closed by this pull request
@guyluz11
Copy link
Collaborator Author

@guyluz11 would merging this close #164?

Nope
This PR contains similar function but not the exact one.
This PR have function to find IP from mdns name and serviceType and the issue is for finding ip from only mdns name.

@git-elliot git-elliot merged commit 54eb109 into osociety:dev Dec 2, 2023
3 of 5 checks passed
@guyluz11 guyluz11 deleted the finding_more_ip_of_mdns branch December 6, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting ip of mdns
2 participants