Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force codepage for windows #194

Merged
merged 2 commits into from
Mar 30, 2024
Merged

Force codepage for windows #194

merged 2 commits into from
Mar 30, 2024

Conversation

git-elliot
Copy link
Collaborator

@git-elliot git-elliot commented Mar 30, 2024

As per documentation of dart_ping force codepage on windows only to fix #190, #191

Ref: https://github.com/point-source/dart_ping/tree/main/dart_ping#non-english-language-support

@git-elliot git-elliot linked an issue Mar 30, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.61%. Comparing base (09bd58a) to head (90a886c).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #194      +/-   ##
==========================================
+ Coverage   75.48%   75.61%   +0.12%     
==========================================
  Files          23       23              
  Lines         567      570       +3     
==========================================
+ Hits          428      431       +3     
  Misses        139      139              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@git-elliot git-elliot merged commit d829d4a into dev Mar 30, 2024
5 checks passed
@git-elliot git-elliot deleted the codepage branch March 30, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormatException: Missing extension byte (at offset 3) in Windows Unhandled exception in Windows 10 chinese
1 participant