Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report: Jobs last success date subsection #75

Merged
merged 7 commits into from
Aug 2, 2024
Merged

Report: Jobs last success date subsection #75

merged 7 commits into from
Aug 2, 2024

Conversation

Crola1702
Copy link
Contributor

Description

This PR adds the jobs failing subsection defined in #57 (comment)

Changes

  • get_known_issues.sql script has a new parameter to filter by known issue status (open, closed)
    • close_old_known_issues.sh uses the new parameter to reduce the amount of code
  • Two new sql queries added to check jobs that have failed for a certain amount of time (created in this buildfarmer-log)
  • Buildfarm tools lib now contains wrappers for the two queries mentioned above
  • "jobs_failing" subsection implemented to report the jobs that have never passed or that have been failing for more than "X" days
    • Report contains job_name and last_success, the format is a simple table showing this information

Example reports:

@Crola1702
WIP old known issues
8c7898b 
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702
Pass filter issues responsibility to sqlite
79da796 
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702
Add jobs_failing section to lib, report and formatter
72ed919 
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702
Remove unused code
bafda2a 
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702
Remove filter_known
261f764 
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702
Refactor to use args
5b5f47a 
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702
Remove unused code
52210f8 
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702 Crola1702 requested a review from Blast545 July 31, 2024 03:44
@Crola1702 Crola1702 self-assigned this Jul 31, 2024
Blast545
Blast545 approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, in general LGTM

database/scripts/lib/buildfarm_tools.rb Show resolved Hide resolved
database/scripts/lib/report_formatter.rb Show resolved Hide resolved
@Crola1702 Crola1702 merged commit a6fb47c into main Aug 2, 2024
@Crola1702 Crola1702 deleted the Crola1702/jobs_failing-section branch August 2, 2024 16:25
Crola1702 added a commit that referenced this pull request Aug 2, 2024
@Crola1702
Revert "Report: Jobs failing subsection (#75)"
ffc328f 
This reverts commit a6fb47c.
@Crola1702 Crola1702 changed the title Report: Jobs failing subsection Report: Jobs last success date subsection Aug 2, 2024
Crola1702 added a commit that referenced this pull request Aug 2, 2024
@Crola1702
Report: Jobs Last Success Date subsection (#75) PR comments
5fbfc5b 
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blast545 Blast545 Blast545 approved these changes

Assignees

@Crola1702 Crola1702

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Crola1702 @Blast545