Report Section: Test regressions all #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Blast545
approved these changes
Sep 4, 2024
Comment on lines
+28
to
+31
| report_regressions_all = BuildfarmToolsLib::test_regressions_all(filter_known: true) | ||
| report_regressions_consecutive = BuildfarmToolsLib::test_regressions_today(filter_known: true, only_consistent: true, group_issues: true, report_regressions: report_regressions_all) | ||
| report_regressions_flaky = BuildfarmToolsLib::flaky_test_regressions(filter_known: true, group_issues: true, report_regressions: report_regressions_all) | ||
|
|
There was a problem hiding this comment.
Why was this moved outside the report creation below?
There was a problem hiding this comment.
test_regressions_all method returns every test regression that happened in the last build. test_regressions_today and flaky_test_regressions run that method internally.
This is an optimization to not fetch all test regressions twice, but use only one run for both
Ahhh I forgot to add it. Good catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. This is the implementation of test_regressions_all section discussed in: #57 (comment)