Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignition-rendering0: use newer commit #457

Merged
merged 6 commits into from
Aug 24, 2018

Conversation

dhood
Copy link
Contributor

@dhood dhood commented Jul 31, 2018

Context is in https://bitbucket.org/ignitionrobotics/ign-rendering/issues/28
This is the first time I've done this. I'm copying #450. I think the other commits must get generated automatically somehow.

This version of ignition rendering requires an updated version of ignition cmake: see #458

@scpeters
Copy link
Member

scpeters commented Aug 3, 2018

the bottle builds failed; maybe @iche033 has some insight?

@dhood
Copy link
Contributor Author

dhood commented Aug 3, 2018

I tried to narrow down what the cause might be @iche033 and here's where I got:

In #458 we bottled ignition-cmake up to and including this PR: https://bitbucket.org/ignitionrobotics/ign-cmake/pull-requests/105

Now bottling ignition-rendering0 we end up with this cmake error:

-- Looking for ignition-common2 - found

-- Found FreeImage: TRUE (Required is at least version "3.9") 
-- Looking for FreeImage - found

-- Checking for module 'OGRE >= 1.8'
--   Found OGRE , version 1.9.0
-- Checking for module 'OGRE-RTShaderSystem >= 1.8'
--   Found OGRE-RTShaderSystem , version 1.9.0
-- Checking for module 'OGRE-Terrain >= 1.8'
--   Found OGRE-Terrain , version 1.9.0
-- Checking for module 'OGRE-Overlay >= 1.8'
--   Found OGRE-Overlay , version 1.9.0
Package OGRE was not found in the pkg-config search path.
Perhaps you should add the directory containing `OGRE.pc'
to the PKG_CONFIG_PATH environment variable
No package 'OGRE' found
CMake Error at /usr/local/share/cmake/ignition-cmake1/cmake1/FindIgnOGRE.cmake:112 (BUILD_WARNING):
  Unknown CMake command "BUILD_WARNING".
Call Stack (most recent call first):
  /usr/local/share/cmake/ignition-cmake1/cmake1/IgnUtils.cmake:188 (find_package)
  CMakeLists.txt:47 (ign_find_package)


-- Configuring incomplete, errors occurred!

This is what has changed in ignition-cmake since the last rendering bottle was built on jul 1: this is the diff.

This is what's changed in ignition-rendering's CMakeLists since the last bottling: it finds ogre with ign_find_package(IgnOGRE ...) instead of ign_find_package(OGRE ..).

So I think the swap over to IgnOGRE might be the cause.

@scpeters
Copy link
Member

scpeters commented Aug 3, 2018

I noticed the complaint about Unknown CMake command "BUILD_WARNING" and submitted the following fix to ign-cmake:

@iche033
Copy link
Contributor

iche033 commented Aug 6, 2018

I also ran into a similar problem on ubuntu. I made some fixes to the pkg config path in this PR: https://bitbucket.org/ignitionrobotics/ign-cmake/pull-requests/105

Not sure if it will help here

@chapulina chapulina force-pushed the dhood/bump_ign_rendering branch 2 times, most recently from d068591 to 0734f62 Compare August 7, 2018 19:32
@scpeters
Copy link
Member

I just updated the ign-cmake1 formula, used the latest commit from ign-rendering default, and started new bottle builds

@scpeters scpeters merged commit b845784 into osrf:master Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants