Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Science sensors: detect when spherical coordinates are set #77

Merged
merged 2 commits into from
Nov 13, 2021

Conversation

chapulina
Copy link
Contributor

@mabelzhang , here's the approach I mentioned that we can use to detect when the spherical coordinates are set.

If you run buoyant_tethys.sdf, you'll see the warning message at startup. If you run empty_environment.sdf, you'll see it when the first vehicle is spawned.

Let me know what you think!

…lugin

Signed-off-by: Louise Poubel <louise@openrobotics.org>
Copy link
Collaborator

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tried it, will merge and update in my PR.

@mabelzhang mabelzhang merged commit 3ee3472 into main Nov 13, 2021
@mabelzhang mabelzhang deleted the chapulina/sensors_spherical branch November 13, 2021 04:50
@mabelzhang mabelzhang mentioned this pull request Nov 20, 2021
33 tasks
@caguero caguero mentioned this pull request Nov 2, 2021
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants