ansi_escape_senquences -> ansi_escape_sequences

[clalancette]

This does change the name of a public API. If we are concerned about that, I can instead alias the functions together.

[clalancette]

CI:

• Linux
• Linux-aarch64
• macOS
• Windows

[dirk-thomas]

There is no reason to break public API so please update the change to be backward compatible.

[clalancette]

Done in 3dcc947

[clalancette]

All of the CI warnings were already there in nightlies, so this should be ready for review.

[dirk-thomas]

Actually what branch should this change target? It looks like there are specific crystal and dashing branches...

[dirk-thomas]

At least for crystal that doesn't seem to be reflected in the rosdistro: https://github.com/ros/rosdistro/blob/0ea30fed0bcb564b9e4d5b2d2efd8783e8e3afa9/crystal/distribution.yaml#L995

[dirk-thomas]

Actually what branch should this change target?

master seems ok then.

At least for crystal that doesn't seem to be reflected in the rosdistro

This should be fixed independently of this PR.

[clalancette]

Actually what branch should this change target? It looks like there are specific crystal and dashing branches...

I really mean to target eloquent here (hence master); this is just a typo, so no need to put it into crystal or dashing.

At least for crystal that doesn't seem to be reflected in the rosdistro: https://github.com/ros/rosdistro/blob/0ea30fed0bcb564b9e4d5b2d2efd8783e8e3afa9/crystal/distribution.yaml#L995

But yeah, I see what you mean. I'll submit a PR to rosdistro to update the source to point to the crystal branch instead of master for crystal (dashing already does the right thing here).