-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansi_escape_senquences -> ansi_escape_sequences #53
Conversation
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
There is no reason to break public API so please update the change to be backward compatible. |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Done in 3dcc947 |
All of the CI warnings were already there in nightlies, so this should be ready for review. |
Actually what branch should this change target? It looks like there are specific |
At least for |
This should be fixed independently of this PR. |
I really mean to target eloquent here (hence master); this is just a typo, so no need to put it into crystal or dashing.
But yeah, I see what you mean. I'll submit a PR to rosdistro to update the source to point to the |
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
This does change the name of a public API. If we are concerned about that, I can instead alias the functions together.