Catch all of the spurious warnings from get_event_loop.

[clalancette]

The previous patch that did this only did it for one of the cases, but we actually need to catch this warning for all cases of get_event_loop(). Do that here by wrapping the entire block in catch_warnings(). With this in place, other spurious warnings from downstream packages (like launch) are also quieted.

@cottsay @Voldivh FYI

[clalancette]

CI:

• Linux
• Linux-aarch64
• Windows

[Voldivh]

LGTM!
QQ: I believe this would quiet all the warnings in any case this method is used. From what I recall other packages like launch used this implementation and also created their own methods that uses get_event_loop(), the warnings that comes from those methods should still be appearing right?

[clalancette]

QQ: I believe this would quiet all the warnings in any case this method is used. From what I recall other packages like launch used this implementation and also created their own methods that uses get_event_loop(), the warnings that comes from those methods should still be appearing right?

Yes, that's exactly right. There are still warnings coming from launch from its own uses of get_event_loop, but with this in place there are no warnings that come from osrf_pycommon anymore.