make config parsing strict when starting gobgpd #2834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default policy for gobgp if config is invalid is to start with default policy ACCEPT. This is harmful for our Route Reflectors setup in which we can get spurous routes after unlucky release.
This commit adds
--config-strict
option that makes gobgp do the fatal exit if config is invalid. If option is not specified, gobgpd will still log warning and continue working.It also introduces special facilty logging field similar to the one in syslog. This allows to implement said backward compatibility with
Fatal()
calls with facility "config" being downgraded toWarn()
.Reload behavior is not changed as it is not as harmful (policies are retained in such case).