Add new metrics and add documentation for metrics exported by GoBGP #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds new metrics to GoBGP, inspired by https://github.com/greenpau/gobgp_exporter It also uses Prometheus namespaces for cleaner refactors and the possibility of overriding the metric prefix to accomodate possible conflict with a generic one like "bgp" Signed-off-by: SkalaNetworks <contact@skala.network>
SkalaNetworks
force-pushed
the
metrics
branch
2 times, most recently
from
dd635ae
to
0a3dc43
Compare
Signed-off-by: SkalaNetworks <contact@skala.network>
|
Add more metrics without breaking the current one, right? |
|
@fujita no it doesn't change anything to the previous metrics, they will continue to work as expected, prometheus alerts will continue to work as expected, same for the existing Grafana panels. The use case is monitoring GoBGP through automatic alerting rules (to know when things go wrong, and to assess the health of GoBGP), and display everything on a Grafana panel. |
|
Understood, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Essentially, https://github.com/greenpau/gobgp_exporter becomes redundant as GoBGP gains pretty much the same metrics.
There are no modification to old metrics beside a single helper sligthly changed because of a typo (will not cause any issue for anybody)