refactor(pub): Inline some variables in parseProject()

Signed-off-by: Frank Viernau <frank_viernau@epam.com>
oss-review-toolkit · Sep 5, 2024 · 399d507 · 399d507
1 parent f5b8f6d
commit 399d507
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/plugins/package-managers/pub/src/main/kotlin/Pub.kt b/plugins/package-managers/pub/src/main/kotlin/Pub.kt
@@ -491,22 +491,18 @@ class Pub(
 
     private fun parseProject(definitionFile: File, pubspec: Pubspec, scopes: Set<Scope>): Project {
         // See https://dart.dev/tools/pub/pubspec for supported fields.
-        val rawName = pubspec.name
         val homepageUrl = pubspec.homepage.orEmpty()
-        val repositoryUrl = pubspec.repository.orEmpty()
-        val authors = parseAuthors(pubspec)
-
-        val vcs = VcsHost.parseUrl(repositoryUrl)
+        val vcs = VcsHost.parseUrl(pubspec.repository.orEmpty())
 
         return Project(
             id = Identifier(
                 type = managerName,
                 namespace = "",
-                name = rawName,
+                name = pubspec.name,
                 version = pubspec.version.orEmpty()
             ),
             definitionFilePath = VersionControlSystem.getPathInfo(definitionFile).path,
-            authors = authors,
+            authors = parseAuthors(pubspec),
             // Pub does not declare any licenses in the pubspec files, therefore we keep this empty.
             declaredLicenses = emptySet(),
             vcs = vcs,