-
Notifications
You must be signed in to change notification settings - Fork 308
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(docker): Update Pnpm to the latest version
See also [1]. Note: This brings in two new packages into the expected result for the test project using workspaces, for an unknown reason. Looking at the project setup, it is correct to include these two projects into the result, because they are included into the workspace, see [2]. However, it seems that it would be better to represent these projects as `Project`s in the result, not as `Package`s. That could be done in a future improvement, which probably should also consider changing the test to analyze the whole directory instead of just a single definition file, to get a more end-to-end picture, for a better overview. [1]: https://github.com/pnpm/pnpm/releases/tag/v9.2.0 [2]: https://github.com/oss-review-toolkit/ort/blob/503edeedc8de2bee866e2d308ac5473b69f1d42e/plugins/package-managers/node/src/funTest/assets/projects/synthetic/pnpm-workspaces/package.json#L10-L11 Signed-off-by: Frank Viernau <frank_viernau@epam.com>
- Loading branch information
Showing
2 changed files
with
61 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afdd4fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: This change causes a warning:
14:13:09.078 [DefaultDispatcher-worker-5] WARN org.ossreviewtoolkit.utils.common.CommandLineTool - The command is required in version >=5.0.0 and <9.0.0, but you are using version 9.2.0. This could lead to problems.
afdd4fa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @clemens . I've addressed this with: #8791.