Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the Bundler package manager to use lock file parsing #3309

Closed
sschuberth opened this issue Nov 9, 2020 · 2 comments
Closed

Rewrite the Bundler package manager to use lock file parsing #3309

sschuberth opened this issue Nov 9, 2020 · 2 comments
Assignees
@sschuberth
Labels
analyzer About the analyzer tool enhancement Issues that are considered to be enhancements

Comments

@sschuberth
Copy link
Member

The current Bundler implementation requires gems to really be installed in order to parse dependencies, which is a problem esp. for native gems as they pull in several native dependencies (e.g. g++, ruby2.5-dev etc.) that would blow up our Docker image.

A possible solution to this would be to let Bundler (via JRuby?) create a lock file if not yet preset (or use it straight away if it is present) and parse the lock file as outlined in this discussion.
@sschuberth sschuberth added analyzer About the analyzer tool enhancement Issues that are considered to be enhancements labels Nov 9, 2020
@sschuberth
Copy link
Member Author

Maybe this could also fix #1308 at the same time.

@KorSin KorSin self-assigned this Jan 8, 2021
KorSin pushed a commit to boschglobal/oss-review-toolkit that referenced this issue Jan 20, 2021
Bundler: Remove redundant functions
a53b056 
Closes oss-review-toolkit#3309.

Signed-off-by: Korbinian Singhammer <external.Korbinian.Singhammer2@bosch.io>
KorSin pushed a commit to boschglobal/oss-review-toolkit that referenced this issue Jan 20, 2021
Bundler: Remove redundant functions
202c9a6 
Closes oss-review-toolkit#3309.

Signed-off-by: Korbinian Singhammer <external.Korbinian.Singhammer2@bosch.io>
@KorSin KorSin assigned sschuberth and unassigned KorSin Apr 5, 2021
@sschuberth
Copy link
Member Author

The current Bundler implementation requires gems to really be installed in order to parse dependencies

This has been solved differently via #3514.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sschuberth sschuberth

Labels
analyzer About the analyzer tool enhancement Issues that are considered to be enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sschuberth @KorSin