Migrate Bundler support to JRuby #4595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
jruby
branch
4 times, most recently
from
4375dcf to
f5d4d89
Compare
sschuberth
force-pushed
the
jruby
branch
3 times, most recently
from
8936433 to
833159a
Compare
mnonnenmacher
previously approved these changes
Oct 26, 2021
sschuberth
force-pushed
the
jruby
branch
2 times, most recently
from
deb8db5 to
8157af0
Compare
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
While at it, also move their names to constants. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
For consistency with other no-argument function calls in this script. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
This is to reduce code duplication. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
Most of JRuby is already used by ORT's reporter module anyway, so also use JRuby (in the same version as used by AsciiDoctorJ) here to run the Ruby helper scripts. This will allow to get rid of the external Bundler dependency in an upcoming change. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
No command line tool is called from this class anymore. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
This is not required anymore, actually already as of d282618. Ruby is still required for CocoaPods. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
mnonnenmacher
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.