Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a license finding score #5131

Merged
merged 7 commits into from
Mar 4, 2022
Merged

Introduce a license finding score #5131

merged 7 commits into from
Mar 4, 2022

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

@sschuberth
LicenseFinding: Add an optional score floating point value
4a2354e 
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
@sschuberth
ScanCodeResultParser: Parse the score for license findings
9158e31 
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
@sschuberth
ScanCodeResultParser: Rename LicenseExpression to LicenseMatch
9d0b909 
That name is more fitting as the class contains more than just the
expression.

Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
@sschuberth
Askalono: Parse the score for license findings
eed744d 
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
@sschuberth
BoyterLc: Parse the score for license findings
359f747 
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
@sschuberth
Licensee: Parse the score for license findings
1946347 
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
@sschuberth
ScanOssResultParser: Parse the score for license findings
5687fa8 
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
@sschuberth sschuberth requested a review from a team as a code owner March 4, 2022 10:14
@sschuberth
Copy link
Member Author

Note that FossID does not seem to have the concept of a "score" to parse for.

@sschuberth sschuberth mentioned this pull request Mar 4, 2022
Closed
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #5131 (5687fa8) into main (6566d29) will decrease coverage by 0.00%.
The diff coverage is 94.11%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #5131      +/-   ##
============================================
- Coverage     72.29%   72.29%   -0.01%     
  Complexity     1918     1918              
============================================
  Files           254      254              
  Lines         13627    13633       +6     
  Branches       1913     1914       +1     
============================================
+ Hits           9852     9856       +4     
- Misses         2775     2776       +1     
- Partials       1000     1001       +1
Impacted Files Coverage Δ
...ain/kotlin/scanners/scanoss/ScanOssResultParser.kt 75.55% <66.66%> (-1.72%) ⬇️
scanner/src/main/kotlin/scanners/Askalono.kt 75.43% <100.00%> (ø)
scanner/src/main/kotlin/scanners/BoyterLc.kt 79.03% <100.00%> (+0.34%) ⬆️
scanner/src/main/kotlin/scanners/Licensee.kt 84.78% <100.00%> (+0.33%) ⬆️
...n/kotlin/scanners/scancode/ScanCodeResultParser.kt 93.37% <100.00%> (+0.13%) ⬆️
.../curation/ClearlyDefinedPackageCurationProvider.kt 60.93% <0.00%> (-3.13%) ⬇️
downloader/src/main/kotlin/vcs/Subversion.kt 68.53% <0.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6566d29...5687fa8. Read the comment docs.

mnonnenmacher
mnonnenmacher approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@mnonnenmacher mnonnenmacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a test for the score to AbstractScannerFunTest would be nice.

@sschuberth
Copy link
Member Author

Adding a test for the score to AbstractScannerFunTest would be nice.

I'll look into that separately as that requires some refactoring.

@sschuberth sschuberth merged commit 1079d41 into main Mar 4, 2022
@sschuberth sschuberth deleted the license-finding-score branch March 4, 2022 13:45
@sschuberth
Copy link
Member Author

Adding a test for the score to AbstractScannerFunTest would be nice.

I'll look into that separately as that requires some refactoring.

See #5133.

@sschuberth sschuberth added the release notes Changes that should be mentioned in release notes label Mar 9, 2022
@sschuberth sschuberth mentioned this pull request Apr 25, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnonnenmacher mnonnenmacher mnonnenmacher approved these changes

Assignees
No one assigned
Labels
release notes Changes that should be mentioned in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sschuberth @mnonnenmacher