Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Further advisor config example fix-up #9670

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

fviernau
Copy link
Member

No description provided.

@fviernau fviernau requested review from a team as code owners December 23, 2024 21:25
@fviernau fviernau force-pushed the website-advisor-fix-up-fix-up branch from 00d1635 to 26fdf80 Compare December 23, 2024 21:25
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.10%. Comparing base (6b4e302) to head (232b5c6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9670   +/-   ##
=========================================
  Coverage     68.10%   68.10%           
  Complexity     1294     1294           
=========================================
  Files           249      249           
  Lines          8841     8841           
  Branches        922      922           
=========================================
  Hits           6021     6021           
  Misses         2432     2432           
  Partials        388      388           
Flag Coverage Δ
funTest-docker 65.14% <ø> (ø)
funTest-non-docker 33.28% <ø> (ø)
test-ubuntu-24.04 35.91% <ø> (ø)
test-windows-2022 35.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The recent fix-up, 1d6fcf5, accidentally missed to also introduce the
missing `options` elements.

Signed-off-by: Frank Viernau <x9fviern@zeiss.com>
@fviernau fviernau force-pushed the website-advisor-fix-up-fix-up branch from 26fdf80 to 232b5c6 Compare December 23, 2024 22:27
@sschuberth sschuberth merged commit 85fc02f into main Dec 24, 2024
26 checks passed
@sschuberth sschuberth deleted the website-advisor-fix-up-fix-up branch December 24, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants