make redhat conversion tool downloadable with Pip #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasinner
force-pushed
the
redhat_osv-as-python-module
branch
from
b6af3dc to
d1f8f61
Compare
andrewpollock
requested changes
Sep 12, 2024
jasinner
force-pushed
the
redhat_osv-as-python-module
branch
from
d1f8f61 to
47e5fdc
Compare
|
Sorry about that. I've updated the values to be specific to this module as per your suggestions. |
|
Just putting this in Draft while I attempt to import it using Pip in another project. |
jasinner
force-pushed
the
redhat_osv-as-python-module
branch
4 times, most recently
from
28173c3 to
fb641d7
Compare
Signed-off-by: Jason Shepherd <jshepher@redhat.com>
jasinner
force-pushed
the
redhat_osv-as-python-module
branch
from
fb641d7 to
ff12f74
Compare
Ok, I had to move things around a little bit, but this is importing successfully with Pip now. @andrewpollock can you please have another look and merge if you're happy. |
andrewpollock
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to install the Red Hat converter tool via Pip we need a setup.py. Adding that here.
This change avoids specifying the runtime dependencies in both Pipenv and setup.py by requesting users install the module locally with:
pipenv install -e .As specified in the updated README.md