🌱 Upgrade to go 1.20 #1262
Merged
🌱 Upgrade to go 1.20 #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the docker version is specified as a tag. The comment will just get outdated. Signed-off-by: Spencer Schrock <sschrock@google.com>
at the minimum this is needed to upgrade sigstore/cosign/v2. Signed-off-by: Spencer Schrock <sschrock@google.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
=======================================
Coverage 63.17% 63.17%
=======================================
Files 4 4
Lines 296 296
=======================================
Hits 187 187
Misses 94 94
Partials 15 15 |
laurentsimon
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our dependencies specifies 1.20 in its
go.mod, so the upgrade is failing. (#1254). At some point we'll probably need to bump again to 1.21.Note: our Dockerfile already uses 1.21, but ultimately the runtime behavior is based on whats in our go.mod