🌱 Add step to validate the dist folder content #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UlisesGascon
force-pushed
the
fix/build-issues
branch
7 times, most recently
from
8995c31 to
64366cd
Compare
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
UlisesGascon
force-pushed
the
fix/build-issues
branch
from
64366cd to
3c861a2
Compare
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
UlisesGascon
changed the title
lelia
reviewed
Jun 21, 2024
lelia
reviewed
Jun 21, 2024
lelia
reviewed
Jun 21, 2024
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
justaugustus
approved these changes
Jun 25, 2024
lelia
pushed a commit
to lelia/scorecard-monitor
that referenced
this pull request
Jun 25, 2024
* ci: add step to validate the dist folder content Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com> * chore: update dist folder Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com> * chore: linting Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com> --------- Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
justaugustus
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Fix issue template ossf link Signed-off-by: lelia <le1ia@me.com> * Rebuild js Signed-off-by: lelia <le1ia@me.com> * Address review feedback Signed-off-by: lelia <le1ia@me.com> * Update outdated snapshots for tests Signed-off-by: lelia <le1ia@me.com> * 🌱 Add step to validate the dist folder content (#84) * ci: add step to validate the dist folder content Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com> * chore: update dist folder Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com> * chore: linting Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com> --------- Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com> * Fix merge conflict, rebuild dist files Signed-off-by: lelia <le1ia@me.com> --------- Signed-off-by: lelia <le1ia@me.com> Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com> Co-authored-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes
This change adds a new step in the ci pipeline. The idea is to ensure that the
dist/folder is up to date with the source code of the project. In the past quite often I forgot to do this step as it is a manual process that is not validated on PR submission.In this PR we include in the dist folder changes in the dependencies and critical changes such as #78
Demo
When the folder is not updated:
When the folder is updated: