🌱 Fix race condition in output file test. (#3533)

Signed-off-by: Spencer Schrock <sschrock@google.com>

pkg/scorecard_result_test.go

@@ -99,7 +99,6 @@ func Test_formatResults_outputToFile(t *testing.T) {
 			args: args{
 				opts: &options.Options{
 					Format:      options.FormatJSON,
-					ResultsFile: "result.json",
 					ShowDetails: true,
 					LogLevel:    log.DebugLevel.String(),
 				},
@@ -116,7 +115,6 @@ func Test_formatResults_outputToFile(t *testing.T) {
 			args: args{
 				opts: &options.Options{
 					Format:      options.FormatDefault,
-					ResultsFile: "result.log",
 					ShowDetails: true,
 					LogLevel:    log.DebugLevel.String(),
 				},
@@ -134,6 +132,14 @@ func Test_formatResults_outputToFile(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			t.Parallel()
 
+			// generate a unique result file in a temp directory for every test run to avoid race conditions in the test.
+			// This can happen when ginkgo runs unit tests in parallel (with -p flag)
+			resultFile, err := os.CreateTemp("", "result-file")
+			if err != nil {
+				t.Fatalf("create temp result file: %v", err)
+			}
+			tt.args.opts.ResultsFile = resultFile.Name()
+
 			// Format results.
 			formatErr := FormatResults(tt.args.opts, tt.args.results, tt.args.doc, tt.args.policy)
 			// Delete generated output file at the end of the test.