Skip to content

Commit

Permalink
📖 Patch fix: updated makefile to include unit-test and unit-test-att…
Browse files Browse the repository at this point in the history
…estor and cont… (#2366)

* updated makefile to include unit-test and unit-test-attestor and contributing doc to include e2e-pat

Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com>

* updated docs

Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com>

Signed-off-by: Dave Banerjee <dave.banerjee@ibm.com>
Co-authored-by: Dave Banerjee <Dave.Banerjee@ibm.com>
  • Loading branch information
dvbnrg and Dave Banerjee authored Oct 20, 2022
1 parent bd0de45 commit d7c23c9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 5 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,11 @@ Following the targets that can be used to test your changes locally.
| Command | Description | Is called in the CI? |
| -------- | -------------------------------------------------- | -------------------- |
| make all | Runs go test,golangci lint checks, fmt, go mod tidy| yes |
| make e2e | Runs e2e tests | yes |
| make e2e-pat | Runs e2e tests | yes |

Make sure to signoff your commits before submitting a pull request.

https://docs.pi-hole.net/guides/github/how-to-signoff/

## Permission for GitHub personal access tokens

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ install: $(GOLANGCI_LINT) \
##@ Build
################################## make all ###################################
all: ## Runs build, test and verify
all-targets = build check-linter validate-docs add-projects validate-projects
all-targets = build unit-test unit-test-attestor check-linter validate-docs add-projects validate-projects
.PHONY: all all-targets-update-dependencies $(all-targets) update-dependencies tree-status
all-targets-update-dependencies: $(all-targets) | update-dependencies
all: update-dependencies all-targets-update-dependencies tree-status
Expand Down

0 comments on commit d7c23c9

Please sign in to comment.