Skip to content

Commit

Permalink
🌱 Remove parallel tests because of rate limiting issues. (#2527)
Browse files Browse the repository at this point in the history
- Remove parallel tests because of rate limiting.

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>
  • Loading branch information
naveensrinivasan authored Dec 8, 2022
1 parent f5e6f63 commit fa0592f
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 12 deletions.
1 change: 0 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ linters:
- misspell
- nakedret
- nestif
- paralleltest
- predeclared
- staticcheck
- stylecheck
Expand Down
15 changes: 5 additions & 10 deletions dependencydiff/dependencydiff_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ import (

// Test_fetchRawDependencyDiffData is a test function for fetchRawDependencyDiffData.
func Test_fetchRawDependencyDiffData(t *testing.T) {
t.Parallel()

//nolint
tests := []struct {
name string
dCtx dependencydiffContext
Expand Down Expand Up @@ -69,7 +68,6 @@ func Test_fetchRawDependencyDiffData(t *testing.T) {
}

func Test_initRepoAndClientByChecks(t *testing.T) {
t.Parallel()
//nolint
tests := []struct {
name string
Expand Down Expand Up @@ -129,8 +127,7 @@ func Test_initRepoAndClientByChecks(t *testing.T) {
}

func Test_getScorecardCheckResults(t *testing.T) {
t.Parallel()

//nolint
tests := []struct {
name string
dCtx dependencydiffContext
Expand Down Expand Up @@ -161,7 +158,6 @@ func Test_getScorecardCheckResults(t *testing.T) {
}

func Test_mapDependencyEcosystemNaming(t *testing.T) {
t.Parallel()
//nolint
tests := []struct {
name string
Expand Down Expand Up @@ -217,7 +213,7 @@ func Test_mapDependencyEcosystemNaming(t *testing.T) {
for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
//nolint
err := mapDependencyEcosystemNaming(tt.deps)
if tt.errWanted != nil && errors.Is(tt.errWanted, err) {
t.Errorf("not a wanted error, want:%v, got:%v", tt.errWanted, err)
Expand All @@ -228,8 +224,7 @@ func Test_mapDependencyEcosystemNaming(t *testing.T) {
}

func Test_isSpecifiedByUser(t *testing.T) {
t.Parallel()

//nolint
tests := []struct {
name string
ct pkg.ChangeType
Expand Down Expand Up @@ -267,7 +262,7 @@ func Test_isSpecifiedByUser(t *testing.T) {
for _, tt := range tests {
tt := tt
t.Run(tt.name, func(t *testing.T) {
t.Parallel()
//nolint
result := isSpecifiedByUser(tt.ct, tt.changeTypesToCheck)
if result != tt.resultWanted {
t.Errorf("result (%v) != result wanted (%v)", result, tt.resultWanted)
Expand Down
1 change: 0 additions & 1 deletion e2e/e2e_suite_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ func TestE2e(t *testing.T) {
if val, exists := os.LookupEnv("SKIP_GINKGO"); exists && val == "1" {
t.Skip()
}
t.Parallel()
RegisterFailHandler(Fail)
RunSpecs(t, "E2e Suite")
}
Expand Down

0 comments on commit fa0592f

Please sign in to comment.