Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage hit after updating to go1.21 #3388

Closed
justaugustus opened this issue Aug 14, 2023 · 2 comments
Closed

Code coverage hit after updating to go1.21 #3388

justaugustus opened this issue Aug 14, 2023 · 2 comments

Comments

@justaugustus
Copy link
Member

We took a code coverage hit after updating to go1.21 in #3387.
Not sure if this is a blip, but worth investigating.

Codecov Report

Merging #3387 (9b7c9ae) into main (198aa96) will decrease coverage by 6.22%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3387      +/-   ##
==========================================
- Coverage   74.30%   68.08%   -6.22%     
==========================================
  Files         178      175       -3     
  Lines       12876    12856      -20     
==========================================
- Hits         9567     8753     -814     
- Misses       2766     3593     +827     
+ Partials      543      510      -33     

Originally posted by @codecov[bot] in #3387 (comment)

@spencerschrock
Copy link
Member

This is due to e2e tests which run only on push to main, due to their use of a PAT. So all PRs currently show this 6% decrease, but have the higher coverage when merged.
cc @naveensrinivasan

@naveensrinivasan
Copy link
Member

This is due to e2e tests which run only on push to main, due to their use of a PAT. So all PRs currently show this 6% decrease, but have the higher coverage when merged. cc @naveensrinivasan

Yes, It is the case. I am closing it. Please reopen if you have concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants