🌱 Migrate to go 1.21 #3387
Merged
🌱 Migrate to go 1.21 #3387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
…v variable. Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
raghavkaul
as code owners
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3387 +/- ##
==========================================
- Coverage 74.30% 68.08% -6.22%
==========================================
Files 178 175 -3
Lines 12876 12856 -20
==========================================
- Hits 9567 8753 -814
- Misses 2766 3593 +827
+ Partials 543 510 -33 |
justaugustus
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Thanks @spencerschrock!
(Filed a separate issue for the code coverage hit: #3388)
ashearin
pushed a commit
to kgangerlm/scorecard-gitlab
that referenced
this pull request
Nov 13, 2023
* Bump dockerfiles to 1.21 * Go minimum version should match our go.mod * Bump GitHub action go version to 1.21 and ensure all workflows use env variable. --------- Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Allen Shearin <allen.p.shearin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
dependency update
What is the current behavior?
What is the new behavior (if this is a feature change)?**
use go1.21 for our CI and builds/releases
keep go1.19 in our go.mod as we don't currently use any 1.20 or 1.21 features. this is for our dependents.
Tests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
#3386
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)