🌱 Add soft mem limit to controller k8s spec #2362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
azeemshaikh38,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2362 +/- ##
=======================================
Coverage 40.55% 40.55%
=======================================
Files 112 112
Lines 8822 8822
=======================================
Hits 3578 3578
Misses 4984 4984
Partials 260 260 |
|
Integration tests success for |
latortuga71
pushed a commit
to latortuga71/scorecard
that referenced
this pull request
Oct 27, 2022
* Bump golang docker to 1.19 Signed-off-by: Spencer Schrock <sschrock@google.com> * Add soft memory limit for controller to address OOMKilled. Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: latortuga <latortugaaaa>
N8BWert
pushed a commit
to N8BWert/scorecard
that referenced
this pull request
Nov 28, 2022
* Bump golang docker to 1.19 Signed-off-by: Spencer Schrock <sschrock@google.com> * Add soft memory limit for controller to address OOMKilled. Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
N8BWert
pushed a commit
to N8BWert/scorecard
that referenced
this pull request
Nov 28, 2022
* Bump golang docker to 1.19 Signed-off-by: Spencer Schrock <sschrock@google.com> * Add soft memory limit for controller to address OOMKilled. Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
* Bump golang docker to 1.19 Signed-off-by: Spencer Schrock <sschrock@google.com> * Add soft memory limit for controller to address OOMKilled. Signed-off-by: Spencer Schrock <sschrock@google.com> Signed-off-by: Spencer Schrock <sschrock@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
What is the new behavior (if this is a feature change)?**
GOMEMLIMIT)OOMKilledWhich issue(s) this PR fixes
NONE
Special notes for your reviewer
Will apply the config change to the release test first, and then the production controller after a few days
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)