Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix typo which prevented cron metadata from going to BigQuery dataset #2370

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

spencerschrock
Copy link
Member

Signed-off-by: Spencer Schrock sschrock@google.com

What kind of change does this PR introduce?

bug fix

What is the current behavior?

No metadata is present in the public BigQuery dataset

What is the new behavior (if this is a feature change)?**

Metadata will now be transferred

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

NONE

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

Signed-off-by: Spencer Schrock <sschrock@google.com>
Copy link
Member

@naveensrinivasan naveensrinivasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@naveensrinivasan naveensrinivasan enabled auto-merge (squash) October 19, 2022 18:24
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #2370 (c35a51f) into main (3f58335) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2370   +/-   ##
=======================================
  Coverage   40.61%   40.61%           
=======================================
  Files         112      112           
  Lines        8831     8831           
=======================================
  Hits         3587     3587           
  Misses       4984     4984           
  Partials      260      260           

@github-actions
Copy link

Integration tests success for
[c35a51f]
(https://github.com/ossf/scorecard/actions/runs/3283953810)

@naveensrinivasan naveensrinivasan merged commit 900701c into ossf:main Oct 19, 2022
@spencerschrock spencerschrock deleted the cron-md-fix branch October 19, 2022 18:48
latortuga71 pushed a commit to latortuga71/scorecard that referenced this pull request Oct 27, 2022
Signed-off-by: Spencer Schrock <sschrock@google.com>

Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: latortuga <latortugaaaa>
N8BWert pushed a commit to N8BWert/scorecard that referenced this pull request Nov 28, 2022
Signed-off-by: Spencer Schrock <sschrock@google.com>

Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
N8BWert pushed a commit to N8BWert/scorecard that referenced this pull request Nov 28, 2022
Signed-off-by: Spencer Schrock <sschrock@google.com>

Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
raghavkaul pushed a commit to raghavkaul/scorecard that referenced this pull request Feb 9, 2023
Signed-off-by: Spencer Schrock <sschrock@google.com>

Signed-off-by: Spencer Schrock <sschrock@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants