Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 attestor: Dockerize + small improvements for Cloud Build usage #2456

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

raghavkaul
Copy link
Contributor

@raghavkaul raghavkaul commented Nov 14, 2022

What kind of change does this PR introduce?

Wrap scorecard-attestor into a Dockerfile. Also add sample repos which demonstrate how scorecard-attestor can be used in a Cloudbuild pipeline, and make some small logging fixes.

Which issue(s) this PR fixes

Closes #2136.

Add Docker image for scorecard-attestor

* Add cloudbuild.yaml
* Improve logging

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
@github-actions
Copy link

Integration tests success for
[cd7e00b]
(https://github.com/ossf/scorecard/actions/runs/3463537733)

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #2456 (98964b1) into main (555a7bf) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2456   +/-   ##
=======================================
  Coverage   40.96%   40.97%           
=======================================
  Files         113      113           
  Lines        9271     9270    -1     
=======================================
  Hits         3798     3798           
+ Misses       5197     5196    -1     
  Partials      276      276           

@raghavkaul raghavkaul temporarily deployed to integration-test November 15, 2022 17:33 Inactive
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
@raghavkaul raghavkaul temporarily deployed to integration-test November 15, 2022 17:45 Inactive
@github-actions
Copy link

Integration tests success for
[da31b15]
(https://github.com/ossf/scorecard/actions/runs/3472766577)

@github-actions
Copy link

Integration tests success for
[f46d3e0]
(https://github.com/ossf/scorecard/actions/runs/3472851435)

Attestor.dockerfile Outdated Show resolved Hide resolved
attestor/command/check.go Outdated Show resolved Hide resolved
attestor/command/sign.go Outdated Show resolved Hide resolved
attestor/command/cli.go Outdated Show resolved Hide resolved
@raghavkaul raghavkaul temporarily deployed to integration-test November 15, 2022 23:28 Inactive
@github-actions
Copy link

Integration tests success for
[34cff36]
(https://github.com/ossf/scorecard/actions/runs/3474992307)

Attestor.dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
* debian10 -> 11
* CLI
* Remove logging statements
* Dockerfile

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
@raghavkaul raghavkaul temporarily deployed to integration-test November 17, 2022 14:57 Inactive
@github-actions
Copy link

Integration tests success for
[8032842]
(https://github.com/ossf/scorecard/actions/runs/3489380012)

@spencerschrock spencerschrock temporarily deployed to integration-test November 18, 2022 00:30 Inactive
@github-actions
Copy link

Integration tests success for
[98964b1]
(https://github.com/ossf/scorecard/actions/runs/3493146998)

@spencerschrock spencerschrock merged commit 272cae5 into ossf:main Nov 18, 2022
N8BWert pushed a commit to N8BWert/scorecard that referenced this pull request Nov 28, 2022
…f#2456)

* Dockerize

* Add cloudbuild.yaml
* Improve logging

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

* Add README.md

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

* Address PR comments

* debian10 -> 11
* CLI
* Remove logging statements
* Dockerfile

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
N8BWert pushed a commit to N8BWert/scorecard that referenced this pull request Nov 28, 2022
…f#2456)

* Dockerize

* Add cloudbuild.yaml
* Improve logging

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

* Add README.md

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

* Address PR comments

* debian10 -> 11
* CLI
* Remove logging statements
* Dockerfile

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Signed-off-by: nathaniel.wert <nathaniel.wert@kudelskisecurity.com>
raghavkaul added a commit to raghavkaul/scorecard that referenced this pull request Feb 9, 2023
…f#2456)

* Dockerize

* Add cloudbuild.yaml
* Improve logging

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

* Add README.md

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

* Address PR comments

* debian10 -> 11
* CLI
* Remove logging statements
* Dockerfile

Signed-off-by: Raghav Kaul <raghavkaul@google.com>

Signed-off-by: Raghav Kaul <raghavkaul@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Scorecard policy that helps evaluate results for GCP Binary Authorization
2 participants