⚠️ errors in ErrXXX format #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
cmwylie19
requested review from
naveensrinivasan and
spencerschrock
and removed request for
a team
cmwylie19
temporarily deployed
to
integration-test
GitHub Actions
Inactive
naveensrinivasan
approved these changes
Apr 17, 2024
spencerschrock
approved these changes
Apr 18, 2024
spencerschrock
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix linting expections around errors
FIX Took care of the
//nolint:errnamedirectives while we're doing breaking changes.What is the current behavior?
uses directive to skip lint
What is the new behavior (if this is a feature change)?**
does not skip lint, fixed the errors
Which issue(s) this PR fixes
Fixes #4033
Special notes for your reviewer
From OSSNA workshop
Does this PR introduce a user-facing change?