Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 add support for parsing azure devops urls #4178

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

JamieMagee
Copy link
Contributor

What kind of change does this PR introduce?

Initial part of feature #4177.

Mainly to see if the overall feature would be accepted and if I am following the contribution guidelines correctly, before I put a lot of work into the rest of the implementation.

What is the current behavior?

N/A

What is the new behavior (if this is a feature change)?**

Azure DevOps URLs can now be parsed

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Initial part of #4177

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

Copy link
Contributor

@raghavkaul raghavkaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just one comment.

clients/azuredevops/repo.go Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Jul 1, 2024

This pull request has been marked stale because it has been open for 10 days with no activity

Copy link

github-actions bot commented Aug 3, 2024

This pull request has been marked stale because it has been open for 10 days with no activity

@github-actions github-actions bot added the Stale label Aug 3, 2024
@JamieMagee
Copy link
Contributor Author

@raghavkaul If I've addressed all your comments, could you merge this please?

Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
@raghavkaul raghavkaul merged commit b709aa1 into ossf:main Aug 23, 2024
36 checks passed
@JamieMagee JamieMagee deleted the azure-devops-repo branch August 26, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants