Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 downgrade osv-scanner to v1.9.0 #4461

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

spencerschrock
Copy link
Member

What kind of change does this PR introduce?

cron fix?

What is the current behavior?

Since upgrading to v1.9.1 (#4405) we've had performance issues in the weekly analysis, which may be related to one of the Maven features here.

What is the new behavior (if this is a feature change)?**

Downgrade back to v1.9.0 to see if that resolves the issue. I've also reached out to the osv-scanner team

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Related to #4443 (comment)

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

Since upgrading to v1.9.1 we've had performance issues in the weekly
analysis, which may be related to one of the Maven features here.

Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock spencerschrock requested a review from a team as a code owner December 16, 2024 22:00
@spencerschrock spencerschrock requested review from justaugustus and raghavkaul and removed request for a team December 16, 2024 22:00
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.63%. Comparing base (353ed60) to head (0c29b45).
Report is 85 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4461      +/-   ##
==========================================
+ Coverage   66.80%   68.63%   +1.82%     
==========================================
  Files         230      242      +12     
  Lines       16602    18032    +1430     
==========================================
+ Hits        11091    12376    +1285     
- Misses       4808     4848      +40     
- Partials      703      808     +105     

@justaugustus justaugustus enabled auto-merge (squash) December 17, 2024 02:19
@justaugustus justaugustus merged commit 5e90f2d into ossf:main Dec 17, 2024
38 checks passed
@spencerschrock spencerschrock deleted the downgrade-osv branch December 17, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants