-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate website to Gatsby #109
Comments
Looks amazing to me. Will start working on this soon |
Should we do it in typescript only? |
@siddhant1 I'm not sure what do you mean with the question about typescript. |
By doing it in typescript he means that instead of writing codes in js way for gatsby we will be doing it in ts files and the "ts way" earlier =>"React with Ts" |
I also want to work upon this one coz i am into gatsby these days so it would be kind of a benefit for me |
Yeah ideally it would be in typescript so we can leverage the existing code (and the benefits of ts). There is a gatsby plugin for ts here https://github.com/gatsbyjs/gatsby/tree/master/packages/gatsby-plugin-typescript |
Cool , let's start with moving the routes ! |
How do we start the gatsby transformation... doing it on this repo will break the already present code If there is any other option plzz tell |
I think that the best way is to start a branch here and collaborate on that branch, so we can have the previews that netlify produces and have a single point of tracking progress. What do you think? |
yeah thats the best thing we can do |
I will make my first pr on this today or maybe tomorrow , I think we can build over that |
@siddhant1 and @ashu8912 you should both have access to write to this repo, so create a branch here.
|
will soon create branch "fixme-enhancement-gatsby" or should i name it something else??? |
I don't mind the name, feel free to choose : ) |
ok thanks :) |
@alexdor I don't have rights to write to this repo didn't received any enail |
we will be creating an orphan branch for this gatsby transformation it will be a fresh branch(meaning no ancestors) . And when the project is finally transformed to gatsby we will be removing the master ---Or--- we can copy the content of the master branch to some other repo specifying the old code is Now one thing more as i see for this fixme repo the continuous development feature of netlify @alexdor plzz show your views on this... |
I don't see the reason of starting on orphan branch. A lot of the existing codebase will be reused, it is just a tooling change. Why do you want to create an orphan branch?
|
i thought that starting from orphan and than bootstrapping the code with gatsby cli would be a great idea . coz if master is an ancestor to this newly created branch than we will have the old code also in our branch.... Both options can be done...... |
My recommendation would be to do the following:
But feel free to implement it another way if you think you can find a better one. |
ok that would be great :) |
@alexdor what do you think of next js ? It can help with SEO too. |
@Muljayan why do you think that it would be more beneficial to switch to nextjs instead of gatsby? |
Honestly, I am not familiar with Gatsby, but I am aware that with next.js the head tag, meta tags can be dynamically changed to optimize it for search engines. |
In this project React helmet is taking care of that
…On Mon 4 Mar, 2019, 6:09 PM Muljayan, ***@***.***> wrote:
Honestly, I am not familiar with Gatsby, but I am aware that with next.js
the head tag, meta tags can be dynamically changed to optimize it for
search engines.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#109 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AdJoBozur3ipP2OE253doo-B6Q1CO9cyks5vTRQIgaJpZM4bPj4F>
.
|
Yeah, as @siddhant1 mentioned this project already sets dynamic meta tags (you could also do that with plain js). The main improvement regarding seo is going to be the prerendered pages. Prerendered pages will dicrease the time-to-interactive and will allow the crawlers to parse the website better. Both nextjs and gatsby support prerendering pages (nextjs also supports rendering pages per request based, but we don't need that feature because we don't have so much dynamic content so it wouldn't justify the extra server required to render pages per request). So both technologies are a good candidate. The reason why I suggested gatsby over nextjs is that gatsby has more tooling regarding content sources and because it is more oriented towards static page generation than nextjs. Though I might be wrong, so feel free to convince me otherwise if you think that nextjs is better for this use case :) |
I agree. Since the majority of the site would be static Gatsby would be a good fit. |
Hi @ashu8912, what's the status? Are you still working on this issue? |
Hey @himankpathak I am working on this , I have some changes ready in my branch (breaking though) , I will.be pushing this one soon |
@ashu8912 @siddhant1 hi : ) what's the status of this? |
Basic scaffold is ready , extending now |
Migrating this project to Gatsby will decrease the time-to-interactive for the users and improve site's seo
The text was updated successfully, but these errors were encountered: