Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash in edge mode. #2967

Closed
wants to merge 1 commit into from
Closed

fix crash in edge mode. #2967

wants to merge 1 commit into from

Conversation

johzzy
Copy link
Contributor

@johzzy johzzy commented Mar 14, 2022

Summary

fix crash in edge mode.

Details

crash if run edge, use conf/edge.conf or this config

    cluster {
        mode remote;
        origin xxx;
    }

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #2967 (6a06989) into develop (1a6d94a) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 6a06989 differs from pull request most recent head 8281e66. Consider uploading reports for the commit 8281e66 to get more accurate results

@@           Coverage Diff            @@
##           develop    #2967   +/-   ##
========================================
  Coverage    56.10%   56.10%           
========================================
  Files          153      153           
  Lines        57561    57559    -2     
========================================
  Hits         32294    32294           
+ Misses       25267    25265    -2     

| Impacted Files | Coverage Δ | |'

Translated to English while maintaining the markdown structure:

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/app/srs_app_edge.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_threads.cpp | 63.70% <ø> (ø) | |

'

Translated to English while maintaining the markdown structure:

'| trunk/src/app/srs_app_edge.cpp | 0.00% <0.00%> (ø) | |
| trunk/src/app/srs_app_threads.cpp | 63.70% <ø> (ø) | |


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data'

Translated to English while maintaining the markdown structure:

'> Δ = absolute <relative> (impact), ø = not affected, ? = missing data

Powered by Codecov. Last update 1a6d94a...8281e66. Read the comment docs.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

winlinvip commented Mar 14, 2022

Please provide more background information.

  1. The code fix is for a problem with a call.
  2. The configuration and reproduction steps are just a normal edge configuration.
  3. It is not clear what exactly happened.

TRANS_BY_GPT3

@johzzy johzzy force-pushed the develop branch 3 times, most recently from 313cb3d to c7a16bc Compare March 19, 2022 04:16
@winlinvip winlinvip self-assigned this Mar 19, 2022
@winlinvip winlinvip added the Bug It might be a bug. label Mar 19, 2022
@johzzy johzzy force-pushed the develop branch 2 times, most recently from 36931e7 to 96edede Compare April 1, 2022 07:07
@johzzy johzzy force-pushed the develop branch 3 times, most recently from 8281e66 to f05e2a2 Compare April 11, 2022 03:34
@winlinvip winlinvip force-pushed the develop branch 3 times, most recently from 4395ee1 to 06e8680 Compare June 17, 2022 09:39
@winlinvip winlinvip force-pushed the develop branch 7 times, most recently from 84a9bf3 to 0a9b292 Compare August 11, 2022 12:57
@winlinvip winlinvip force-pushed the develop branch 4 times, most recently from 9c7a9d0 to 38c3d9f Compare September 2, 2022 14:22
@winlinvip winlinvip force-pushed the develop branch 2 times, most recently from 991fdb5 to 02d47c5 Compare November 23, 2022 03:57
@winlinvip winlinvip force-pushed the develop branch 2 times, most recently from 55dce2c to bc381a0 Compare December 31, 2022 04:40
@winlinvip winlinvip force-pushed the develop branch 3 times, most recently from 4ae67f1 to badf33c Compare January 10, 2023 14:08
@winlinvip winlinvip force-pushed the develop branch 2 times, most recently from 500d8fc to 498ce72 Compare January 11, 2023 02:57
@winlinvip winlinvip force-pushed the develop branch 3 times, most recently from c056094 to 2ac9eb8 Compare March 23, 2023 06:02
@johzzy johzzy force-pushed the develop branch 2 times, most recently from c9e837d to be95e78 Compare June 15, 2023 04:10
@johzzy johzzy force-pushed the develop branch 2 times, most recently from 7e95bf5 to 20648a8 Compare June 21, 2023 07:02
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
@winlinvip winlinvip force-pushed the develop branch 2 times, most recently from 0bb9637 to 2e211f6 Compare August 12, 2024 10:42
@johzzy johzzy force-pushed the develop branch 2 times, most recently from d17f402 to 596f770 Compare December 9, 2024 03:10
@johzzy johzzy closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug It might be a bug. TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants