Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite research/api-server code by Go, remove Python. #3382

Merged
merged 19 commits into from
Jan 18, 2023
Merged

Rewrite research/api-server code by Go, remove Python. #3382

merged 19 commits into from
Jan 18, 2023

Conversation

panda1986
Copy link
Contributor

Please describe the summary for this PR.

  1. rewrite python api-server to golang.

@winlinvip
Copy link
Member

winlinvip commented Jan 15, 2023 •
edited
Loading

Please simplify:

  1. Use only one main.go file to avoid multiple go files, which makes searching difficult.
  2. Add a go.mod file by initializing with go mod init api-server.
  3. Remove proxy.go as it is rarely used for CDN preheating HLS.
  4. Remove server.go as the server list is now managed by heartbeat. It is no longer needed for the API and console.
  5. Remove the src directory and place the files directly under api-server.

TRANS_BY_GPT3

@winlinvip winlinvip force-pushed the feature-refine-api-server branch from 6c08221 to 6df11c6 Compare January 15, 2023 05:46
@winlinvip winlinvip changed the title support api-server golang Rewrite research/api-server code by Go, remove Python. Jan 17, 2023
@winlinvip winlinvip force-pushed the feature-refine-api-server branch from 8fd91ad to 16085cd Compare January 18, 2023 04:48
@winlinvip winlinvip merged commit 8156686 into ossrs:develop Jan 18, 2023
winlinvip added a commit that referenced this pull request Jan 18, 2023
@panda1986 @winlinvip
@chundonglinlin @chen-guanghua
Rewrite research/api-server code by Go, remove Python. (#3382)
9600e49 
* support api-server golang

* Update release to v6.0.18 and v5.0.137

PICK 8156686

Co-authored-by: winlin <winlin@vip.126.com>
Co-authored-by: chundonglinlin <chundonglinlin@163.com>
Co-authored-by: ChenGH <chengh_math@126.com>
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chundonglinlin chundonglinlin chundonglinlin left review comments

@chen-guanghua chen-guanghua chen-guanghua approved these changes

@winlinvip winlinvip winlinvip approved these changes

Assignees
No one assigned
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panda1986 @winlinvip @chundonglinlin @chen-guanghua