Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player: Fix empty img tag occupy 20px size in safari. v6.0.142 #4029

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

suzp1984
Copy link
Contributor

@suzp1984 suzp1984 commented Apr 17, 2024

the html img tag occupy 20px size in safari.

<img src='//ossrs.net/gif/v1/sls.gif?site=ossrs.net&path=/player/rtcplayer'/>

Screenshot 2024-04-17 at 9 17 07 AM

(ignore the img css warning: auto\9; it's another problem, I will file another PR.)

but, the empty img tag just occupy 1px size in chrome. So I guess it's a html compatible problem.

Screenshot 2024-04-17 at 9 46 33 AM

TRANS_BY_GPT4

@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Apr 17, 2024
@suzp1984
Copy link
Contributor Author

suzp1984 commented Apr 17, 2024

I guess the //ossrs.net/gif/v1/sls.gif?site=ossrs.net&path=/console/enindex is used for statistics & analysis purpose. but pls pay attention to the path, for some one may not so match with its real path.

e.g.

<img src='//ossrs.net/gif/v1/sls.gif?site=ossrs.net&path=/console/cnindex'/>

<img src='//ossrs.net/gif/v1/sls.gif?site=ossrs.net&path=/player/srsplayer'/>

<img src='//ossrs.net/gif/v1/sls.gif?site=ossrs.net&path=/player/rtcpublisher'/>

<img src='//ossrs.net/gif/v1/sls.gif?site=ossrs.net&path=/player/rtcpublisher'/>

@suzp1984 suzp1984 force-pushed the debug/empty-img-size branch from 35f8a04 to ca29cd6 Compare July 9, 2024 08:06
@winlinvip winlinvip changed the title fix empty img tag occupy 20px size in safari. Player: Fix empty img tag occupy 20px size in safari. Jul 24, 2024
@winlinvip winlinvip changed the title Player: Fix empty img tag occupy 20px size in safari. Player: Fix empty img tag occupy 20px size in safari. v6.0.142 Jul 24, 2024
@winlinvip winlinvip added the RefinedByAI Refined by AI/GPT. label Jul 24, 2024
@winlinvip winlinvip merged commit 3e1a4e4 into ossrs:develop Jul 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RefinedByAI Refined by AI/GPT. TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants