-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/vood 48 use recommended linting rules #9
Merged
alexandre-lagadec-ost
merged 8 commits into
master
from
ci/VOOD-48_use-recommended-linting-rules
Oct 24, 2021
Merged
Ci/vood 48 use recommended linting rules #9
alexandre-lagadec-ost
merged 8 commits into
master
from
ci/VOOD-48_use-recommended-linting-rules
Oct 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-lagadec-ost
requested review from
PascalSchuermannOst and
GinoCardillo-OST
October 18, 2021 21:21
Is it possible to enforce an explicit return type? So a |
Yes, there is such a rule. |
GinoCardillo-OST
approved these changes
Oct 24, 2021
alexandre-lagadec-ost
force-pushed
the
ci/VOOD-48_use-recommended-linting-rules
branch
from
October 24, 2021 20:34
b9861cb
to
3afa9ba
Compare
alexandre-lagadec-ost
deleted the
ci/VOOD-48_use-recommended-linting-rules
branch
October 24, 2021 20:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.