Refactor/remove codegen #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilativ-dotcom
requested changes
Sep 18, 2024
...em-solver/cxx/identifiers-module/agent/translate_main_system_idtfs_from_sc_to_file_agent.cpp
Outdated
Show resolved
Hide resolved
...em-solver/cxx/identifiers-module/agent/translate_main_system_idtfs_from_sc_to_file_agent.cpp
Outdated
Show resolved
Hide resolved
...em-solver/cxx/identifiers-module/agent/translate_main_system_idtfs_from_sc_to_file_agent.cpp
Outdated
Show resolved
Hide resolved
...em-solver/cxx/identifiers-module/agent/translate_main_system_idtfs_from_sc_to_file_agent.cpp
Outdated
Show resolved
Hide resolved
...em-solver/cxx/identifiers-module/agent/translate_main_system_idtfs_from_sc_to_file_agent.cpp
Outdated
Show resolved
Hide resolved
...rm-dependent-components/problem-solver/cxx/sections-module/agent/get_decomposition_agent.cpp
Outdated
Show resolved
Hide resolved
...rm-dependent-components/problem-solver/cxx/sections-module/agent/get_decomposition_agent.cpp
Outdated
Show resolved
Hide resolved
platform-dependent-components/problem-solver/cxx/sections-module/agent/remove_section_agent.cpp
Show resolved
Hide resolved
platform-dependent-components/problem-solver/cxx/sections-module/agent/remove_section_agent.cpp
Outdated
Show resolved
Hide resolved
...ependent-components/problem-solver/cxx/sections-module/test/units/add_section_agent_test.cpp
Outdated
Show resolved
Hide resolved
kilativ-dotcom
approved these changes
Sep 19, 2024
...em-solver/cxx/identifiers-module/agent/translate_main_system_idtfs_from_sc_to_file_agent.cpp
Outdated
Show resolved
Hide resolved
platform-dependent-components/problem-solver/cxx/sections-module/agent/add_section_agent.cpp
Outdated
Show resolved
Hide resolved
| #include "keynodes/identifiers_keynodes.hpp" | ||
| #include "translate_main_system_idtfs_from_sc_to_file_agent.hpp" | ||
|
|
||
| using namespace identifiersModule; | ||
|
|
||
| SC_AGENT_IMPLEMENTATION(TranslateMainSystemIdtfsFromScToFileAgent) | ||
| ScResult TranslateMainSystemIdtfsFromScToFileAgent::DoProgram(ScActionInitiatedEvent const & event, ScAction & action) |
There was a problem hiding this comment.
this agent has question_initiated in docs translate_agent_input.png
| streamIdtfs << "{\"" << mainIdentifier << "\", " | ||
| << "{\"" << systemIdentifier << "\", \"" << stringType << "\"}},\n"; | ||
| streamIdtfs << R"({")" << mainIdentifier << R"(", )" | ||
| << R"({")" << systemIdentifier << R"(", ")" << stringType << R"("}},\n)"; |
There was a problem hiding this comment.
everything is printed in one line with \n between entries, I guess previously they were separated with newline
MakarenkoAI
commented
Sep 19, 2024
| ScTemplateResultItem genResult; | ||
| context->GenerateByTemplate(scTemplate, genResult); | ||
|
|
||
| if (genResult.Size() != 0) |
There was a problem hiding this comment.
not sure about this condition
There was a problem hiding this comment.
you can just get from genResult by alias
genResult shouldn't be empty if scTemplate isn't empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.