-
Notifications
You must be signed in to change notification settings - Fork 27
Conversation
I'm doing some other clap-v3 porting, so I can take this over too. |
67268e9
to
ebf97fd
Compare
For a start, I rebased the branch and brought it to green CI state. |
This reworks CLI handling logic, porting to latest clap v3.
Ok, porting here is completed and this is ready for review. |
Yeah in some conversation over at https://www.reddit.com/r/rust/comments/xqiqfy/clap_400_a_rust_argument_parser_is_released/ it seems like some people were aware a v4 was coming and held off porting from v2. But, I guess since we're doing this we might as well do v4? Potentially related to this, we could split off the CLI code into a separate crate with its own semver churn. Definitely some cost/benefit to that. Anyways...yeah I think I'd say we should go v4, but I haven't tried the port either myself. I can do it if you like. |
@cgwalters when we land this, the clap-v4 update should be just a Cargo manifest bump (as this PR already gets rid of all the planned deprecations). |
LGTM as is but I can't approve this as it's my own PR so...feel free to approve 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (feels like cheating) 😄
Oh, right. Well, we forgot to bump semver for this. Urgh. Well...ok. In practice I can't imagine anything is using this API except rpm-ostree. If something is, well, I can't imagine we're causing them that much pain. |
This reworks CLI handling logic, porting to latest clap v3.
Closes: #373