Two deployment stage prep patches #1514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prep for deployment staging. We had the code to hande "explicit kargs" in one place, but the "use merge deployment" karg bits mixed in with the "/etc merge" logic. Those are separate things, and it's better to have karg handling in one place.
For staged deploy, we want to pay the cost of creating copies from `/usr/etc` → `/etc` at stage time, since it can be expensive. (We want to minimize time spent during shutdown). Split it up into two functions; the logic is also simply clearer.
|
Nice! @rh-atomic-bot r+ 81aa7a0 |
|
⚡ Test exempted: merge already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Mar 26, 2018
For staged deploy, we want to pay the cost of creating copies from `/usr/etc` → `/etc` at stage time, since it can be expensive. (We want to minimize time spent during shutdown). Split it up into two functions; the logic is also simply clearer. Closes: #1514 Approved by: jlebon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prep for #1503