lib/deploy: Port final bootconfig writing to new style #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Mar 26, 2018
| * jump in and open a file there. See above TODO | ||
| * around doing this in a new mount namespace. | ||
| */ | ||
| int errsv = errno; |
There was a problem hiding this comment.
I know this isn't new, but that line confuses me. Was the intent here to save errno before the "finally" mount and restore it afterwards?
There was a problem hiding this comment.
I think it's more that in the past I've been bitten by the error handling functions themselves overwriting errno. Imagine if e.g. you want to do g_strdup_printf() to format an error message, and then go on to reference errno.. But in this case it's safe to drop.
The main blocker for doing this before was the `goto out` handling for remounting `/boot`. Handle that by factoring out the bits that require it to a helper function, and do the C/GError equivalent of "try/finally". Not prep for anything right now, just decided to do this since I had the file open.
cgwalters
force-pushed
the
deploy-more-style
branch
from
d65af19
to
cf603f2
Compare
|
☀️ Test successful - status-atomicjenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main blocker for doing this before was the
goto outhandlingfor remounting
/boot. Handle that by factoring out the bits thatrequire it to a helper function, and do the C/GError equivalent of
"try/finally".
Not prep for anything right now, just decided to do this since I had the file
open.