curl: Add more assertions for curl return values #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup to the previous curl fixes; if we'd had an assertion earlier debugging the failure would have been more obvious. All of these are "should not fail" cases so asserting is right.
|
Sometimes I prefer using exec(curl ...) rather than libcurl as I find it easier to debug and it's more memory safe, I guess OSTree does so many requests the forking gets too expensive, LGTM... |
jlebon
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to the previous curl fixes; if we'd had an assertion earlier debugging the failure would have been more obvious.
All of these are "should not fail" cases so asserting is right.