Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rangement des données statiques #2344

Merged
merged 21 commits into from
Oct 31, 2024
Merged

Rangement des données statiques #2344

merged 21 commits into from
Oct 31, 2024

Conversation

arnaudlevy
Copy link
Member

@arnaudlevy arnaudlevy commented Oct 18, 2024

Création d'un partial admin/application/static/core pour ranger les données communes à tous les statics

date: 2023-06-19T14:05:40+02:00
lastmod: 2024-10-17T10:48:27+02:00
meta:
  hugo:
    permalink: "/fr/"
    file: "content/fr/_index.html"
    path: ""
    slug: ""
  dates:
    created_at: 2023-06-19T14:59:53+02:00
    updated_at: 2024-10-17T10:48:27+02:00
    published_at: 2023-06-22T14:57:37+02:00

@arnaudlevy arnaudlevy changed the title Rangement des métadonnées statiques Rangement des données statiques Oct 18, 2024
Copy link
Member

@SebouChu SebouChu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 petits commentaires.

En global, à discuter mais je trouve le partial un peu illisible entre les différentes conditions imbriquées etc, peut-être quelque chose à reprendre ensemble.

A voir si de la même manière que forced_slug, on aurait un forced_date

et ranger un peu les conditions de sorte à rendre le partial lisible de haut en bas sans difficulté

app/views/admin/application/static/_core.html.erb Outdated Show resolved Hide resolved
app/views/admin/research/publications/static.html.erb Outdated Show resolved Hide resolved
@arnaudlevy arnaudlevy merged commit 16659fc into main Oct 31, 2024
6 checks passed
@arnaudlevy arnaudlevy deleted the object-dates branch October 31, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants