Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[a11y] Amélioration du menu #773

Merged
merged 4 commits into from
Nov 26, 2024
Merged

[a11y] Amélioration du menu #773

merged 4 commits into from
Nov 26, 2024

Conversation

alexisben
Copy link
Contributor

@alexisben alexisben commented Nov 26, 2024 •
edited
Loading

Type

  • Nouvelle fonctionnalité
  • Bug
  • Ajustement
  • Rangement

Description

#747

  • Modifier le aria-label du bouton par “menu”
  • Faire boucler le focus dans le header jusqu'à fermeture du menu
  • Quand utilisateur ouvre le menu déplacer dans l'ordre du code source le nav.upper-menu après le nav avec le aria-label menu principal

Niveau d'incidence

  • Incidence faible 😌
  • Incidence moyenne 😲
  • Incidence forte 😱

@alexisben
Copy link
Contributor Author

Vérifier CIDS / MIDS et Communication publique

@alexisben alexisben merged commit 628e1a9 into main Nov 26, 2024
3 checks passed
@alexisben alexisben deleted the menu-a11y branch November 26, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaudlevy arnaudlevy Awaiting requested review from arnaudlevy arnaudlevy is a code owner

@SebouChu SebouChu Awaiting requested review from SebouChu SebouChu is a code owner

@pabois pabois Awaiting requested review from pabois pabois is a code owner

@Olivia206 Olivia206 Awaiting requested review from Olivia206 Olivia206 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexisben