Champs de contacts et réseaux sociaux : uniformisation #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olivia206
requested review from
arnaudlevy,
SebouChu,
pabois and
alexisben
as code owners
arnaudlevy
reviewed
Dec 6, 2024
| @@ -136,14 +136,15 @@ | |||
| @include media-breakpoint-down(md) | |||
| padding-bottom: 0 | |||
| dd | |||
| display: flex | |||
There was a problem hiding this comment.
pas compris les modifs de ce fichier
There was a problem hiding this comment.
C'est relatif aux captures d'écran plus haut : l'affichage des listes de campus sur une formation sont un peu cassées quand les campus chassent à la ligne
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Partie thème de osunyorg/admin#2459
On a des changements dans plusieurs partials :
commons/socials.html: on ajoute une clé de vérification pour accéder à l'email + on met à jour chaque champ avec .valuecommons/address, on enlève le niveau.postal_addresspour ne garder queParams.contact_detailscar.htmln'est plus à l'intérieur de.datablocks/templates/contact.htmlon remet à niveau les différentes cléscommons/contact-details.htmlon ajoute une vérification des champs disponiblesEt en bonus, j'ai vu que sur les héros d'une formation listant les campus, on avait une
margin-leftqui décalait le texte (cf. screens plus bas), c'est réparé.Niveau d'incidence
URL de test sur recette
Pages de personne, orga, footer, block contact...
Screenshots