Prise en compte du markdown dans les titres de menu #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olivia206
requested review from
arnaudlevy,
SebouChu,
pabois and
alexisben
as code owners
arnaudlevy
approved these changes
Dec 18, 2024
| @@ -62,7 +62,7 @@ | |||
|
|
|||
| {{- if ne .kind "blank" -}} | |||
| <a href="{{ .target }}" {{ with $link_class }} class="{{ . }}" {{ end }} {{ safeHTMLAttr $attributes }} {{ safeHTMLAttr $title_attribute }}> | |||
| {{ .title }} | |||
| {{ .title | markdownify }} | |||
There was a problem hiding this comment.
Tu penses qu'on applique sur tous les titres du menu ?
(Je me suis dit que oui mais est-ce assez sûr ?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Est-ce qu'il faut ajouter ce paramètre en option du partial menu, scoper son usage, ou est-ce une utilisation assez limitée pour que ça reste contrôlé/contrôlable ?
Niveau d'incidence
URL de test du site (optionnel)
On en a besoin pour Communication publique (a minima sur le upper menu)
Screenshots