Style des liens actifs du upper menu : ajout de la possibilité de choisir entre site et page active
#828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olivia206
requested review from
arnaudlevy,
SebouChu,
pabois and
alexisben
as code owners
alexisben
reviewed
Dec 19, 2024
Comment on lines
+115
to
+117
| $upper-menu-active-selector: '.active' | ||
| @if $header-upper-menu-active-style-for-sites | ||
| $upper-menu-active-selector: ':not([href*="https://"], [href*="http://"])' |
There was a problem hiding this comment.
Pourquoi c'est l'un ou l'autre ? ça peut pas être les deux ?
There was a problem hiding this comment.
ça risque de prêter à confusion, non ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Actuellement on ciblait la classe
.activedans le upper menu pour ajouter le style avec la bordure grise en bas du lien. Le problème est que plusieurs sites utilisent plutôt ce upper menu pour naviguer dans un éco-système, le sélecteur n'est donc plus approprié.On ajoute une variable
$header-upper-menu-active-style-for-sitesà faux par défaut : si elle esttrue, alors notre sélecteur change et devient:not(a[href*=“https://“], a[href*=“http://“](soit : tout ce qui n'est pas un lien externe) (nb : il faut impérativement mettre/en url du site actif)Le style va s'adapter aux changements de la variable dans
header.sass.Niveau d'incidence