Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer: updated Polaris22Fixup #279

Merged
merged 6 commits into from
Jun 24, 2020
Merged

installer: updated Polaris22Fixup #279

merged 6 commits into from
Jun 24, 2020

Conversation

osy
Copy link
Owner

@osy osy commented Jun 16, 2020

* Use Lilu again
* Patch works on resume (fixes #206)
* Fix kernel panic on bootup without workaround (fixes #1)
* Above means booting with latest AMD GPU drivers works, this may fix other
  issues as well.
Also fix installer option for reset boot-args getting unchecked
@iiicwx
Copy link

iiicwx commented Jun 16, 2020

Thank you @osy86 , just test it, Apple TV+ works again, still have to go through a sleep though.

@osy
Copy link
Owner Author

osy commented Jun 16, 2020

That’s weird I still can’t get it to work just as before.

@iiicwx
Copy link

iiicwx commented Jun 16, 2020

@osy86 maybe mini dp to dp? @crhendo also uses mini dp who confirmed me on #131

@osy
Copy link
Owner Author

osy commented Jun 16, 2020

I am currently using miniDP to DP running on 10.15.5. My monitor is a LG 4k 60hz display with freesync. HDCP is enabled. I tried both amd codec option and intel codec option.

* Intel encoder needed for Sidecar support
* AMD encoder seems broken (lots of artifacts)
* Intel decoder is broken for H.264 content at 120 FPS
@osy
Copy link
Owner Author

osy commented Jun 17, 2020

@KrisCris I've updated the package so Intel option also uses AMD decoder and Intel encoder (AMD option uses AMD encoder+decoder). So sidecar should work. Make sure to select "reset boot-args" when installing as the boot-args have changed.

Also due to a bug in macOS, sandboxed apps like Quicktime cannot read the AppleGVA settings. So I install a new script /Applications/QuickTime Fix.app which you have to run once and then you can delete it.

To fix the 120 FPS HEVC decode issue for QuickTime, run the provided script
installed to /Applications for each user of the system.
@crhendo
Copy link

crhendo commented Jun 18, 2020

I would like to give this a try however I lack the skills on how to install these new branches. Is there an updated HaCMini.pkg file that I can access or something I should read that would give me a clue on how to test new branches?

As always, any help would be very much appreciated.

@goodbest
Copy link
Collaborator

I don't have issue #1 #262 or #206 previously, so I couldn't help testing this PR for those issue..

For the DRM thing, I don't know if I'm alone.
Intel Codec:

  • Apple TV+ Episodes (with fp4? hw4 maybe), video = Black screen, audio = fine
  • Purchased iTunes Episodes (with fp1? sw maybe), work fine.

AMD Codec:

  • Apple TV+ Episodes (with fp4? hw4 maybe), video = green glitches, audio = fine
  • Purchased iTunes Movie (with fp1? sw maybe), work fine.

By the way,
In WEG Shiki, it says AMD Polaris Ellesmere is broken in 10.15 (e.g. RX 590).
Not sure whether it's still the case in 10.15.5
https://github.com/acidanthera/WhateverGreen/blob/a5abdbd7dffc85ebbddbac19a1820873b280b214/WhateverGreen/kern_shiki.hpp#L72

@osy
Copy link
Owner Author

osy commented Jun 18, 2020

In WEG Shiki, it says AMD Polaris Ellesmere is broken in 10.15 (e.g. RX 590).
Not sure whether it's still the case in 10.15.5

#1 (comment) Claims it’s fixed

@iiicwx
Copy link

iiicwx commented Jun 18, 2020

tried the test built 71&73, apple tv+ not working.

@osy
Copy link
Owner Author

osy commented Jun 18, 2020

Those are the wrong branch. 69 is the latest one for this branch. You can also click the “details” link below.

Installer/Package.pkgproj Outdated Show resolved Hide resolved
@osy osy merged commit ae99f04 into master Jun 24, 2020
@osy osy deleted the update-gpu-drivers branch June 24, 2020 03:06
@osy osy mentioned this pull request Aug 14, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants