fix

ota-meshi · Sep 15, 2023 · 3757a92 · 3757a92
1 parent 155f057
commit 3757a92
Show file tree

Hide file tree

Showing 2 changed files with 60 additions and 0 deletions.
diff --git a/lib/rules/require-unicode-sets-regexp.ts b/lib/rules/require-unicode-sets-regexp.ts
@@ -4,6 +4,29 @@ import { createRule, defineRegexpVisitor } from "../utils"
 import { RegExpParser, visitRegExpAST } from "@eslint-community/regexpp"
 import { toUnicodeSet } from "regexp-ast-analysis"
 
+const CLASS_SET_RESERVED_DOUBLE_PUNCTUATORS = [
+    "&&",
+    "!!",
+    "##",
+    "$$",
+    "%%",
+    "**",
+    "++",
+    ",,",
+    "..",
+    "::",
+    ";;",
+    "<<",
+    "==",
+    ">>",
+    "??",
+    "@@",
+    "^^",
+    "``",
+    "~~",
+    "--",
+]
+
 /**
  * Returns whether the regex would keep its behavior if the v flag were to be
  * added.
@@ -25,6 +48,13 @@ function isCompatible(regexpContext: RegExpContext): boolean {
                 if (!us.equals(vus)) {
                     throw INCOMPATIBLE
                 }
+                if (
+                    CLASS_SET_RESERVED_DOUBLE_PUNCTUATORS.some((punctuator) =>
+                        node.raw.includes(punctuator),
+                    )
+                ) {
+                    throw INCOMPATIBLE
+                }
             },
         })
     } catch (error) {

diff --git a/tests/lib/rules/require-unicode-sets-regexp.ts b/tests/lib/rules/require-unicode-sets-regexp.ts
@@ -46,5 +46,35 @@ tester.run("require-unicode-sets-regexp", rule as any, {
             output: null, // Converting to the v flag changes the behavior of the character set.
             errors: ["Use the 'v' flag."],
         },
+        ...[
+            "&&",
+            "!!",
+            "##",
+            "$$",
+            "%%",
+            "**",
+            "++",
+            ",,",
+            "..",
+            "::",
+            ";;",
+            "<<",
+            "==",
+            ">>",
+            "??",
+            "@@",
+            "^^",
+            "``",
+            "~~",
+        ].map((punctuator) => ({
+            code: String.raw`/[a${punctuator}b]/u`,
+            output: null, // Converting to the v flag changes the behavior of the character set.
+            errors: ["Use the 'v' flag."],
+        })),
+        {
+            code: String.raw`/[+--b]/u`,
+            output: null, // Converting to the v flag changes the behavior of the character set.
+            errors: ["Use the 'v' flag."],
+        },
     ],
 })